Fix coupled model with 32bit compilation#143
Merged
mike-hobson merged 4 commits intoMetOffice:mainfrom Jan 16, 2026
Merged
Conversation
github-actions
bot
added
the
cla-signed
mike-hobson
approved these changes
Jan 16, 2026
Contributor
mike-hobson
left a comment
mike-hobson
left a comment
There was a problem hiding this comment.
This is a really straightforward change to the kind of a variable used in the coupling prognostics. I'm happy for this to PASS code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @mike-hobson
A JULES variable used by the coupling module is defined as double precision. It's used in calculations in LFRic coupling code that are carried out in single precision if 32 bit compilation is used. In this change a copy of the variable is created at the working precision of LFRic so that the coupled model can be used in double or single precision.
Code Quality Checklist
Testing
This change has been used in the coupled climate and coupled NWP workflows since apps2.2 with no problems.
trac.log
Test Suite Results - lfric_apps - i134_fix_coupled_32bit/run1
Suite Information
Task Information
✅ succeeded tasks - 1106
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
Trivial change - so Sci/Tech has been skipped.
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review