Merged
Conversation
jennyhickson
requested review from
andrewcoughtrie,
cameronbateman-mo and
mo-nikosbaltas
and removed request for
a team
andrewcoughtrie
approved these changes
Sep 1, 2025
Collaborator
andrewcoughtrie
left a comment
andrewcoughtrie
left a comment
There was a problem hiding this comment.
I've checked it out an built it all looks good so I'm happy. I presume we are making this public in the same way we did the LFRic Core docs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed publishing the docs in their current state so that people can start to access the docs that have been written. Since these docs are a work in progress I'm adding a banner to highlight this.
I have built the docs to confirm the banner displays as intended.
There was also a warning of a duplicate label - I removed the one from the psyclone page as this felt out of place and I suspect was a copy and paste error.