Skip to content

Log to rank zero only by default#186

Merged
ericaneininger merged 4 commits intoMetOffice:mainfrom
tommbendall:TBendall/LogRankZero
Jan 30, 2026
Merged

Log to rank zero only by default#186
ericaneininger merged 4 commits intoMetOffice:mainfrom
tommbendall:TBendall/LogRankZero

Conversation

@tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Jan 28, 2026

PR Summary

Sci/Tech Reviewer: @thomasmelvin
Code Reviewer: @ericaneininger

This is a simple PR, which sets the rose-stem default for log_to_rank_zero to be .true., for all apps.

This option writes log files only on the first rank, rather than on all -- turning on the option that was added in https://code.metoffice.gov.uk/trac/lfric/ticket/4577. Logging on all ranks for all tests in the test-suite creates thousands of unused files, using unnecessary energy and data when these files are left behind. It would be better to only turn this option on when needing to debug.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - log_rank_zero/run1

Suite Information

Item Value
Suite Name log_rank_zero/run1
Suite User thomas.bendall
Workflow Start 2026-01-28T08:53:36
Groups Run suite_default
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@2025.12.1 True
lfric_apps tommbendall/lfric_apps@TBendall/LogRankZero False
lfric_core MetOffice/lfric_core@2025.12.1 True
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

✅ succeeded tasks - 1106

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 28, 2026
@tommbendall tommbendall added this to the Spring 2026 milestone Jan 28, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Jan 28, 2026
@tommbendall tommbendall marked this pull request as ready for review January 28, 2026 15:25
@github-actions github-actions bot requested a review from thomasmelvin January 28, 2026 15:25
Copy link
Contributor

@thomasmelvin thomasmelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

Copy link
Contributor

@ericaneininger ericaneininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with this. Happy to approve.

@ericaneininger ericaneininger merged commit 456fa99 into MetOffice:main Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants