Improve negative mass error message#187
Conversation
jameskent-metoffice
left a comment
There was a problem hiding this comment.
This change edits the failing gracefully message to make it more useful to users. The new message is very helpful and a big improvement on the old one. I'm happy to approve.
mo-alistairp
left a comment
There was a problem hiding this comment.
Happy with these changes, the updated error messages seem like a sensible improvement.
|
It seems that |
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
PR Summary
Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @mo-alistairp
This is a simple change which updates one of the model's most common error messages, removing a typo and improving the instructions for model users.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - better_lipschitz_error/run2
Suite Information
Task Information
✅ succeeded tasks - 1106
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review