Skip to content

Bugfix for linear upgrade macro #347

Merged
t00sa merged 4 commits intoMetOffice:stablefrom
james-bruten-mo:fix_linear_meta
Mar 9, 2026
Merged

Bugfix for linear upgrade macro #347
t00sa merged 4 commits intoMetOffice:stablefrom
james-bruten-mo:fix_linear_meta

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Mar 6, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @t00sa

An issue with an upgrade macro containing a capitalised letter meant the macro wasn't applied correctly by rose, but rose didn't raise an errorcode, meaning it wasn't noticed. This PR changes the capitalisation of Blevs_m to blevs_m everywhere, and then upgrades the missed apps from the previous meta version to the head of the macro chain (vn3.1).

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - linear_meta_hotfix/run1

Suite Information

Item Value
Suite Name linear_meta_hotfix/run1
Suite User james.bruten
Workflow Start 2026-03-07T14:39:13
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2026.03.1 True
jules MetOffice/jules@2026.03.1 True
lfric_apps james-bruten-mo/lfric_apps@fix_linear_meta False
lfric_core MetOffice/lfric_core@2026.03.1 True
moci MetOffice/moci@2026.03.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True
socrates MetOffice/socrates@2026.03.1 True
socrates-spectral MetOffice/socrates-spectral@2026.03.1 True
ukca MetOffice/ukca@2026.03.1 True

Task Information

✅ succeeded tasks - 1511

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@james-bruten-mo james-bruten-mo requested a review from t00sa March 9, 2026 09:31
@james-bruten-mo james-bruten-mo marked this pull request as ready for review March 9, 2026 09:31
Copy link
Collaborator

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@t00sa t00sa merged commit 0b1651e into MetOffice:stable Mar 9, 2026
12 of 13 checks passed
@cameronbateman-mo cameronbateman-mo added this to the Summer 2026 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants