Lfric2lfric multi cpu test#392
Open
Juan Manuel Castillo Sanchez (ukmo-juan-castillo) wants to merge 6 commits intoMetOffice:mainfrom
Open
Lfric2lfric multi cpu test#392Juan Manuel Castillo Sanchez (ukmo-juan-castillo) wants to merge 6 commits intoMetOffice:mainfrom
Juan Manuel Castillo Sanchez (ukmo-juan-castillo) wants to merge 6 commits intoMetOffice:mainfrom
Conversation
Contributor
Lottie Turner (mo-lottieturner)
left a comment
There was a problem hiding this comment.
It looks like checksum_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_4cpu_azspice_gnu_fast-debug-64bit.txt is the same as checksum_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_1cpu_azspice_gnu_fast-debug-64bit.txt - have you checked the other new kgos to see if they are the same as their single-cpu equivalents?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: mo-marqh
This PR simply adds rose stem tests to compare running lfric2lfric with multiple CPUs.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric2lfric_multi_CPU_test/run1
Suite Information
Task Information
✅ succeeded tasks - 106
I just run the lfric2lfric tests as they are the only ones affected by these changes. I compared results with #275 and they do not change. Output generated with 1 CPU and multiple CPUs is the same.
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review