Transmute explicit no Transformation list and global.py#56
Conversation
github-actions
bot
added
the
cla-signed
…dy up the other sites too, else they will get an error. Add placeholder global.pys and symlink identical directories with meto-ex1a which is the most up to date.
oakleybrunt
left a comment
oakleybrunt
left a comment
There was a problem hiding this comment.
Thanks Ben, looks good to me and has gotten rid of a lot of files that didn't need to be there.
One thing I'm a little confused about is there are lots of single line changes to paths like applications/lfric_atm/optimisation/cpu-azngarch-sandbox/transmute/science. Are these symlinks you're adding?
Otherwise, see formatting suggestions on CLA and question about tech debt. Happy to approve when these are actioned
CONTRIBUTORS.md
Outdated
| | GitHub user | Real Name | Affiliation | Date | | ||
| | ----------- | --------- | ----------- | ---- | | ||
| | james-bruten-mo | James Bruten | Met Office | 2025-12-09 | | ||
| | jennyhickson | Jenny Hickson | Met Office | 2025-12-10 | | ||
| | mo-marqh | mark Hedley | Met Office | 2025-12-11 | |
There was a problem hiding this comment.
| | GitHub user | Real Name | Affiliation | Date | | |
| | ----------- | --------- | ----------- | ---- | | |
| | james-bruten-mo | James Bruten | Met Office | 2025-12-09 | | |
| | jennyhickson | Jenny Hickson | Met Office | 2025-12-10 | | |
| | mo-marqh | mark Hedley | Met Office | 2025-12-11 | | |
| | GitHub user | Real Name | Affiliation | Date | | |
| | --------------- | ------------- | ----------- | ---------- | | |
| | james-bruten-mo | James Bruten | Met Office | 2025-12-09 | | |
| | jennyhickson | Jenny Hickson | Met Office | 2025-12-10 | | |
| | mo-marqh | mark Hedley | Met Office | 2025-12-11 | |
There was a problem hiding this comment.
Has a follow-up issue been created to track all of the global.py files that need filling?
There was a problem hiding this comment.
I don't think I've moved that one across yet. I'll create and link that here.
Sci/Tech Review
|
Thanks Oakley, yeah for now. I'm a bit torn how to handle the external sites otherwise. I've been quite diligent and only linked the directories where they are otherwise identical to us. They can always amend it. I think the other LFRic Applications which are lfric_atm like (ngarch and coupled), should be sim linked for now, but yeah the external sites I'm on the fence about, but leaning towards the above note. Side note, Jed can no longer review this, so I'll get a new CR. |
Co-authored-by: Oakley Brunt <130391369+oakleybrunt@users.noreply.github.com>
|
Thanks Ben, I just didn't know if GitHub was trying to show me symlinks or something else. I think these are fine to use :) |
|
Last thing to do is resolve the conflicts on your branch and get the Legal check to pass, then I can move it to Code Review |
Should be resolved now! Email has been sent to SSD for new CR btw |
|
@oakleybrunt as a SR, could you please approve the PR before this can go for CR? |
|
@oakleybrunt can you fill in the SciTech review boxes in the PR template at the top of the ticket please? |
Done :) |
mo-lottieturner
left a comment
mo-lottieturner
left a comment
There was a problem hiding this comment.
Approved pending testing
github-actions
bot
added
cla-modified
6 participants
PR Summary
Sci/Tech Reviewer: @oakleybrunt
Code Reviewer: @mo-lottieturner
Linked issue: #49
Linked FCM Trac ticket: Apps:900
Linked planned Documentation update: #25
Planned follow up tech debt ticket: #86
The primary goal of this ticket is to lift aspects like the options list, which was common across scripts, but initialised for a particular script, and collate this to allow the creation of a global script.
All of the newer scripts were often using copies of identical code.
This ticket creates a bucket script which is read in, and given a specific file name, the bespoke sections, originally across multiple scripts, are utilised by a single file.
It also mandates in the make system that if we want to use PSyclone on a file, without a script, it needs to be explicitly stated, otherwise the global script is used.
To ensure this rigidity, the no script line is moved to a script which is only called if the user specifies the file needs a PSyclone pass without a file.
To accommodate this change, and ensure other sites are not adversely affected, I've done a bit of housekeeping other the sites directories, adding dummy global scripts where required, or sym-linking whole directories like Transmute's PSyKal cousin.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
and have tests been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_apps - transmute_explicit_list_overrides2/run1
Suite Information
Task Information
✅ succeeded tasks - 1104
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
inteface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review