Skip to content

#8 PSyclone transformation scripts documentation#9

Merged
yaswant merged 4 commits intoMetOffice:mainfrom
oakleybrunt:main
May 6, 2025
Merged

#8 PSyclone transformation scripts documentation#9
yaswant merged 4 commits intoMetOffice:mainfrom
oakleybrunt:main

Conversation

@oakleybrunt
Copy link
Contributor

@oakleybrunt oakleybrunt commented Apr 2, 2025

Closes #8

@oakleybrunt oakleybrunt requested review from a team as code owners April 2, 2025 10:36
@oakleybrunt oakleybrunt requested review from ericaneininger, james-bruten-mo and mike-hobson and removed request for a team April 2, 2025 10:36
@oakleybrunt oakleybrunt changed the title #8 PSyclone docs start #8 PSyclone transformation scripts documentation Apr 2, 2025
@oakleybrunt
Copy link
Contributor Author

oakleybrunt commented Apr 8, 2025

@james-bruten-mo @ericaneininger @mike-hobson Can I check one of you has seen this please? Thanks!

james-bruten-mo
james-bruten-mo requested changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification needed on where some of the files you've mentioned live, but otherwise looks good.

@james-bruten-mo
Copy link
Collaborator

james-bruten-mo commented May 1, 2025

You also need to add the psyclone/index to the developer_guide/index toctree

james-bruten-mo
james-bruten-mo approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Oakley, that looks good to me now

@oakleybrunt
Copy link
Contributor Author

oakleybrunt commented May 1, 2025

Thanks James :)

I don't have merge access, is the policy in this repo for the developer to merge? If so I'll need my permissions updated!

@yaswant
Copy link
Collaborator

yaswant commented May 1, 2025

Thanks James :)

I don't have merge access, is the policy in this repo for the developer to merge? If so I'll need my permissions updated!

Hi Oakley,

  • Merge to main should be done by repo admins/maintainers only.
  • Its not ideal to self-merge own branches to main.

We can always revisit roles in future.

ericaneininger
ericaneininger approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ericaneininger ericaneininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yaswant yaswant merged commit 3ca7df9 into MetOffice:main May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaswant yaswant yaswant approved these changes

@ericaneininger ericaneininger ericaneininger approved these changes

@james-bruten-mo james-bruten-mo james-bruten-mo approved these changes

@mike-hobson mike-hobson Awaiting requested review from mike-hobson mike-hobson was automatically assigned from MetOffice/core-capability-development

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Documentation]: Document PSyclone transformation scripts

4 participants

@oakleybrunt @james-bruten-mo @yaswant @ericaneininger