Merged
Conversation
Steve Mullerworth (stevemullerworth)
requested a review
from a team
as a code owner
Contributor
mo-lucy-gordon
left a comment
mo-lucy-gordon
left a comment
There was a problem hiding this comment.
I have left some comments about small changes to a few sections. Otherwise this reads well overall, and builds correctly.
documentation/source/user_guide/lfric_datamodel/external_field.rst
Outdated
Show resolved
Hide resolved
documentation/source/user_guide/lfric_datamodel/function_space.rst
Outdated
Show resolved
Hide resolved
documentation/source/user_guide/lfric_datamodel/function_space.rst
Outdated
Show resolved
Hide resolved
Collaborator
Author
Steve Mullerworth (stevemullerworth)
left a comment
Steve Mullerworth (stevemullerworth)
left a comment
There was a problem hiding this comment.
Hopefully dealt with all issues
mo-lucy-gordon
approved these changes
Sep 5, 2024
mo-lucy-gordon
requested changes
Sep 5, 2024
Contributor
mo-lucy-gordon
left a comment
mo-lucy-gordon
left a comment
There was a problem hiding this comment.
Please merge in changes from MetOffice:main branch
mo-lucy-gordon
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding user documentation for most of the more fundamental LFRic data structures: fields, field proxies, field collections, operators, scalars, function spaces (and quadrature rules).