Clean up the data model doc and move it to developer documentation#89
Conversation
There was a problem hiding this comment.
This appears as the start of a new page, so there are no "issues above".
There was a problem hiding this comment.
Fixed this and one other point where more context was required (this section came from the original data model doc).
Ricky Wong (mo-rickywong)
left a comment
There was a problem hiding this comment.
Good, relocation of sections to the developer guide. Majority of issues are more to to with wording and typos rather than actual content
There was a problem hiding this comment.
| grid. The new LFRic atmosphere model uses the GungHo formulation for its | |
| grid. The LFRic atmosphere model uses the GungHo formulation for its |
There was a problem hiding this comment.
Done
There was a problem hiding this comment.
| represented by a combination of data points on entities of a mesh and a set of | |
| represented by a combination of data points on the entities of a mesh and a set of |
There was a problem hiding this comment.
Done
There was a problem hiding this comment.
"and others" ?
There was a problem hiding this comment.
"the LFRic field is a Fortran type
that, among other properties, encapsulates all these aspects of the field."
Changed to this.
documentation/source/developer_guide/core_data_model/science_model_architecture.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
| (c) Crown copyright 2023 Met Office. All rights reserved. | |
| (c) Crown copyright 2024 Met Office. All rights reserved. |
There was a problem hiding this comment.
Done (it was a copy of the 2023 version, but, whatevah!)
|
Responded to all comments. I have chosen not to take the suggestion relating to repeated use of "support" for reasons given, but have changed several of the items in line with requests. |
After some discussion, it was suggested that the user documentation be much more focused on technical descriptions of each aspect of the LFRic system and more compact, and that the original data model that described the PSyKAl architecture and how LFRic worked alongside PSyclone should be moved to developer documentation (it was agreed that it may not be an ideal location but it was better than either user documentation or the getting going section).
This pull request makes those changes. It also makes changes to what was called lfric_datamodel: