Skip to content

Feature/130#133

Merged
filippomc merged 17 commits intodevelopmentfrom
feature/130
Mar 16, 2020
Merged

Feature/130#133
filippomc merged 17 commits intodevelopmentfrom
feature/130

Conversation

@rodriguez-facundo
Copy link
Copy Markdown
Contributor

  • Update to @material-ui v4
  • Components working as expected
  • Bring netpyne-geppetto repository to NetPyNE-UI
  • Merge with File Upload / Download functionality for docker containers

Watch out

  • Casper tests are broken for good
  • Styling was not included
  • Merging with development will trigger CF staging deployment

Next steps

  • Bring redux branch to development after this branch is merge
  • Test that all minor sync issues solved in redux branch are not broken

@rodriguez-facundo rodriguez-facundo added the enhancement New feature or request label Mar 10, 2020
@rodriguez-facundo rodriguez-facundo self-assigned this Mar 10, 2020
Copy link
Copy Markdown
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis doesn't look happy. What about removing for now all tests that are failing? @rodriguez-facundo @ddelpiano
We can also remove support to python 2.x and test on python 3.7+ only

@rodriguez-facundo
Copy link
Copy Markdown
Contributor Author

yeap, will do that!

@rodriguez-facundo
Copy link
Copy Markdown
Contributor Author

Hi @filippomc 👋, this branch is deployed here http://34.68.113.100 with all the fixes we discussed on friday. It includes the redux stuff to remove geppetto triggers (a PR that was pending in netpyne-geppetto).

cc: @ddelpiano

@filippomc
Copy link
Copy Markdown
Contributor

The demo looks much better, still problems with Travis I can see

@rodriguez-facundo
Copy link
Copy Markdown
Contributor Author

rodriguez-facundo commented Mar 16, 2020

Removed casper test in travis.

@filippomc filippomc merged commit 6ccd6f5 into development Mar 16, 2020
@filippomc filippomc deleted the feature/130 branch March 19, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants