add cellArgs to import cell template #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianq
approved these changes
Jul 3, 2018
Contributor
adrianq
left a comment
adrianq
left a comment
There was a problem hiding this comment.
Looks good to me just waiting to merge MetaCell/geppetto-netpyne#35
Contributor
|
@rodriguez-facundo I found a bug while doing the final tests. When importing a cell or a model we change the current folder to a different one (to compile the mod files, etc.) and revert this change at the end of the method. If there was an error at any point it will goes straight to the catch clause without changing back the current folder. Next time, the user opens the dialog he will be in a subfolder without the possibility of exploring the parent folder. Fix with a 'finally' clause. May have to do with #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this requires: MetaCell/geppetto-netpyne#35
we are adding cellArgs field (a dictionary) to import cell template and also retaining the conds that were defined before clicking import template.
There is a difference between the type dict and the type netpyne.specs.dict. This difference was causing troubles to import a cell template and was also causing the app to hang. So, in order to retain the conds defined before importing, this PR is required