#385 limit initial dom objects rendered in jsonviewer#418
Merged
filippomc merged 1 commit intodevelopmentfrom Nov 15, 2021
Merged
#385 limit initial dom objects rendered in jsonviewer#418filippomc merged 1 commit intodevelopmentfrom
filippomc merged 1 commit intodevelopmentfrom
Conversation
filippomc
approved these changes
Nov 5, 2021
Contributor
filippomc
left a comment
filippomc
left a comment
There was a problem hiding this comment.
Like the solution, thanks @Muhaddatha. We may even take this further and collapse to the 2nd/3rd level. @ddelpiano what do you think?
Member
@filippomc looks good to me 👍🏽 |
filippomc
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some objects in the JSON like
secsandsecsListshad a lot of items, the rendering was slowed down. So, I collapsed JSON objects/arrays with a depth of 7 or more to speed up the rendering and reduce lagging.