temporary changes to plot rxd in panel 3 #54
Conversation
adrianq
left a comment
adrianq
left a comment
There was a problem hiding this comment.
@salvadord A couple of comments...
netpyne_ui/netpyne_geppetto.py
Outdated
|
|
||
| return svgs.__str__() | ||
|
|
||
| def getNetPyNERxDConcentration(self): |
There was a problem hiding this comment.
@salvadord Can we name this method following the standard, i.e. 'getNetPyNERxDConcentrationPlot'?
There was a problem hiding this comment.
yes, can rename to that
netpyne_ui/netpyne_geppetto.py
Outdated
|
|
||
| def getNetPyNERxDConcentration(self): | ||
| try: | ||
| fig = rxd.plotExtracellularConcentration(species=rxd.ca) |
There was a problem hiding this comment.
Is it not needed to import rxd for this to work?
There was a problem hiding this comment.
this is just a temporary hack for the tutorial, so for this to work the user has to run from the jupyter nb: import gui_tut3_rxd as rxd
There was a problem hiding this comment.
Actually, you can just do 'from neuron import crxd as rxd', can't you? and we are already doing sth similar with matplotlib here
NetPyNE-UI/netpyne_ui/netpyne_geppetto.py
Line 21 in e000520
If what I am saying is correct is almost the same thing we are doing with matplotlib and I wouldn't consider it as hacky solution.
There was a problem hiding this comment.
it's not the same as rxd -- I shouldn't really have called it rxd (it was just to make it shorter).
the module I'm importing is custom made for the tutorial: https://github.com/Neurosim-lab/netpyne_workspace/blob/CNS18/gui_tut3_rxd.py
this is just temporary so can see the rxd plot properly... don't freak out! ;)