Feature/480 disable sentry#589
Merged
ddelpiano merged 4 commits intodevelopmentfrom Nov 15, 2022
Merged
Conversation
ddelpiano
requested changes
Nov 10, 2022
Member
ddelpiano
left a comment
ddelpiano
left a comment
There was a problem hiding this comment.
The fix per se is correct, however right now we don't have a single job in the package.json that makes a production build, so when testing this sentry is always active.
Could we update also the package.json to add a production mode build, plus enhance the utilities/installation.py to take care of that?
Thanks
ddelpiano
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.