#518 fix: Fix "Save to json" ignored options

[aranega]

Fixes #518

This PR fixes the options that are passed to

When I check/uncheck options, they options are well passed/removed from the include variable in Python that is passed to sim.saveData(include) (line 606 of this PR in netpyne_geppetto.py)
However, whether I uncheck all options or I check all of them, the produced json always includes this:

"saveDataInclude": [
      "netParams",
      "netCells",
      "netPops",
      "simConfig",
      "simData"
    ],

Is it a normal behavior of the saveData(...) method in NetPyNE?

[ddelpiano]

Fixes #518

This PR fixes the options that are passed to

When I check/uncheck options, they options are well passed/removed from the include variable in Python that is passed to sim.saveData(include) (line 606 of this PR in netpyne_geppetto.py) However, whether I uncheck all options or I check all of them, the produced json always includes this:

"saveDataInclude": [
      "netParams",
      "netCells",
      "netPops",
      "simConfig",
      "simData"
    ],

Is it a normal behavior of the saveData(...) method in NetPyNE?

ccing @salvadord since he could give us more info on the above.

Thanks!

[aranega]

@ddelpiano @salvadord Here are the options that are passed to the saveData function depending on what you check in the save modal:

Save with "netParams, simConfig"
param passed to the saveData function of NetPyNE ['netParams', 'simConfig']

Save with None options:
param passed to the saveData function of NetPyNE []

Save with "netParams"
param passed to the saveData function of NetPyNE ['netParams']

Save with "netParams, simConfig, netCells" ('netPops' is automatically added because of 'netCells')
param passed to the saveData function of NetPyNE ['netParams', 'netCells', 'simConfig', 'netPops']

Save with "netParams, simConfig, netCells, simData" ('netPops' is automatically added because of 'netCells')
param passed to the saveData function of NetPyNE ['netParams', 'netCells', 'simConfig', 'simData', 'netPops']

[vvbragin]

Fixes #518

This PR fixes the options that are passed to

When I check/uncheck options, they options are well passed/removed from the include variable in Python that is passed to sim.saveData(include) (line 606 of this PR in netpyne_geppetto.py) However, whether I uncheck all options or I check all of them, the produced json always includes this:

"saveDataInclude": [
      "netParams",
      "netCells",
      "netPops",
      "simConfig",
      "simData"
    ],

Is it a normal behavior of the saveData(...) method in NetPyNE?

Yes, it is expected. This saveDataInclude is part of simConfig, and the items in this list doesn't get affected by whta os passed as include into sim.saveData() call. Instead, it serves as default saving options in case no includeis passed to that method call.