Skip to content

#604 fix: Fix issue w/ model double instanciation #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelpiano merged 1 commit into from
Dec 16, 2022
Merged

#604 fix: Fix issue w/ model double instanciation #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions netpyne_ui/netpyne_geppetto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ def instantiateNetPyNEModelInGeppetto(self, args):
try:
with redirect_stdout(sys.__stdout__):
if not args.get("usePrevInst", False):
if self.doIhaveInstOrSimData()['haveInstance']:
Copy link
Copy Markdown
Member

@ddelpiano ddelpiano Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a check for the rxdParams key, if empty or not (as discussed at the call).

sim.clearAll()
netpyne_model = self.instantiateNetPyNEModel()
self.geppetto_model = self.model_interpreter.getGeppettoModel(netpyne_model)

Expand Down Expand Up @@ -259,7 +261,7 @@ def simulate_single_model(self, experiment: model.Experiment = None, use_prev_in
netpyne_model = self.instantiateNetPyNEModel()

self.geppetto_model = self.model_interpreter.getGeppettoModel(netpyne_model)

simulations.run()

if self.geppetto_model:
Expand Down Expand Up @@ -374,7 +376,7 @@ def _prepare_simulation_files(self, experiment: model.Experiment = None, use_pre

def _prepare_batch_files(self, experiment: model.Experiment) -> str:
"""Creates template files and netpyne model files in the experiment folder.

Only for an experiment consisting of many trials.

:param experiment: given experiment
Expand Down