Feature/643 fix 'Model' > 'Simulate Network' also instantiates the model#647
Merged
ddelpiano merged 3 commits intodevelopmentfrom Jan 30, 2023
Merged
Feature/643 fix 'Model' > 'Simulate Network' also instantiates the model#647ddelpiano merged 3 commits intodevelopmentfrom
ddelpiano merged 3 commits intodevelopmentfrom
Conversation
Contributor
|
It works correctly now
an error is no longer displayed and the model is correctly simulated. Screen.Recording.2023-01-12.at.15.50.06.movAdditionally, the loader text now has the expected 'Simulating the model' 'Instantiating and Simulating' works properly as well Screen.Recording.2023-01-12.at.15.59.18.mov |
ddelpiano
requested changes
Jan 19, 2023
ddelpiano
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643