Skip to content

Fix/netpyne 143 #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelpiano merged 2 commits into from
Apr 25, 2023
Merged

Fix/netpyne 143 #721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03a078c
netpyne-143 Fix size of tutorial bubble
aranega Apr 24, 2023
0e73a50
natus-143 Fix placement tutorial bubble when overflow on X axis
aranega Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions webapp/components/general/TutorialBubble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ const TutorialBubble = ({
const windowHeight = window.innerHeight;
const windowWidth = window.innerWidth;

let x = rect1.left + (rect1.width / 2) - (width2 / 2);
let y = (rect1.top - windowHeight) + rect1.height;
// let x = rect1.left + (rect1.width / 2) - (width2 / 2); // bubble is aligned with center of the rectangle
let x = rect1.left; // bubble is aligned with the left of the rectangle
let y = (rect1.top - windowHeight) + rect1.height + rectMargin;

// Check if element2 is outside the viewport horizontally
if (x + width2 > windowWidth) {
x = rect1.left - width2;
// x = rect1.left - width2;
x = rect1.left - ((x + width2) - windowWidth + rectMargin);
}

if (x < 0) {
Expand Down Expand Up @@ -141,7 +143,7 @@ const TutorialBubble = ({
}

const targetRect = DOMtarget.getBoundingClientRect();
const { x, y } = calculateVisiblePosition(targetRect, 150, 300);
const { x, y } = calculateVisiblePosition(targetRect, 400, 184);

const hasOtherSteps = requestedTourStep < steps.length;
const nextIsVisible = nextDOMtarget?.checkVisibility();
Expand Down