Fix/renaming and deleting component#73
Closed
ddelpiano wants to merge 3 commits intodevelopmentfrom
Closed
Conversation
…handle also empty strings
adrianq
reviewed
Sep 19, 2018
Contributor
adrianq
left a comment
adrianq
left a comment
There was a problem hiding this comment.
@ddelpiano Maybe we can move the import inside the function. What about keeping a single log command? Traces are already particularly verbose in some bits of the code
Member
Author
|
closing this in favour of #77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed renaming function for the components that allow it, now it can handle also empty strings.
This PR is linked to this other one MetaCell/geppetto-netpyne#66