fixed installation script if a different branch is defined in the scr…#78
Merged
adrianq merged 1 commit intodevelopmentfrom Oct 2, 2018
Merged
fixed installation script if a different branch is defined in the scr…#78adrianq merged 1 commit intodevelopmentfrom
adrianq merged 1 commit intodevelopmentfrom
Conversation
…ipt itself to be used
adrianq
reviewed
Oct 2, 2018
Contributor
adrianq
left a comment
adrianq
left a comment
There was a problem hiding this comment.
Not sure about this @ddelpiano I think @tarelli implemented this logic that way so travis tests work properly (checking out the same branch for all the repos). @tarelli ?
Member
|
@adrianq I had the variable names swapped. It basically worked by chance for months. |
Contributor
|
Understood. Merging it... |
adrianq
approved these changes
Oct 2, 2018
Contributor
|
@ddelpiano @tarelli I think we shouldn't have merged this PR. The original logic was correct at least when testing branches/PRs. I am not reverting it yet so we can discuss it tomorrow... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adrianq this is to fix the issue we faced the other day, it is a tiny bug in the logic of the checkout we are using at the moment. Make much more sense to swap branch and default_branch the other way around if you guys agree.