Feature/ch 199 200 elasticsearch and env confs#813
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the official Elastic helm chart for Elasticsearch with custom tweaks, including removal of the built-in security in favor of Gatekeeper and support for environment-specific configuration overrides.
- Integrated the official Elastic helm chart and made necessary adjustments to resources and security probes.
- Added support for override configuration files ([FILE]-[ENV].yaml/json) and enabled testing through Helm test hooks.
Reviewed Changes
Copilot reviewed 20 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| applications/elasticsearch/deploy/charts/values-dev.yaml | Added resource and storage configuration for the development environment. |
| applications/elasticsearch/deploy/charts/templates/test/test-elasticsearch-health.yaml | Introduced a test pod for Elasticsearch health checks using a Helm hook. |
| applications/elasticsearch/deploy/charts/templates/statefulset.yaml | Configured the StatefulSet with updated templates including security contexts, affinity rules, and readiness probes. |
| applications/elasticsearch/deploy/charts/templates/serviceaccount.yaml | Created a ServiceAccount resource when RBAC creation is enabled. |
| applications/elasticsearch/deploy/charts/templates/service.yaml | Defined both standard and headless services for the Elasticsearch pods. |
| applications/elasticsearch/deploy/charts/templates/secret*.yaml | Set up secrets for credentials and TLS certificates with dynamic generation as needed. |
| applications/elasticsearch/deploy/charts/templates/role*.yaml and podsecuritypolicy.yaml | Configured RBAC resources; note the PodSecurityPolicy implementation. |
| applications/elasticsearch/deploy/charts/templates/networkpolicy.yaml and ingress.yaml | Established network rules and ingress for HTTP and transport traffic. |
| applications/elasticsearch/deploy/charts/templates/configmap.yaml and _helpers.tpl | Provided configuration templates and helper functions for naming and certificate generation. |
| applications/elasticsearch/deploy/charts/Chart.yaml, .helmignore, Makefile, and README.md | Updated chart metadata, build helpers, and documentation. |
Comments suppressed due to low confidence (1)
applications/elasticsearch/deploy/charts/templates/podsecuritypolicy.yaml:3
- The PodSecurityPolicy resource is defined using apiVersion 'policy/v1beta1', which is deprecated in newer Kubernetes versions (>=1.25). Consider updating this resource to a supported alternative or providing a migration plan.
apiVersion: policy/v1beta1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-199
Closes CH-200
Implemented solution
CH-199
added helm chart from https://github.com/elastic/helm-charts/tree/main/elasticsearch
Main tweaks:
CH-200
now can add [FILE]-[ENV].(yaml|json) anywhere in configurations, including templates and charts. The ENV version will override anything within [FILE].(yaml|json)
How to test this PR
...
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):