Skip to content

feat: Make custom on_exit_notify task more flexible#817

Merged
filippomc merged 5 commits intodevelopfrom
feature/CH-188
Oct 2, 2025
Merged

feat: Make custom on_exit_notify task more flexible#817
filippomc merged 5 commits intodevelopfrom
feature/CH-188

Conversation

@afonsobspinto
Copy link
Copy Markdown
Member

@afonsobspinto afonsobspinto commented Sep 15, 2025

Closes https://metacell.atlassian.net/browse/CH-188

Implemented solution

  • Checks if queue and payload are present in the on_exit_notify param before trying to retrieve them.

How to test this PR

Added a couple more new unit tests for the different on exit notify scenarios f.e:

    on_exit_notify = {
        'image': 'my-custom-exit-handler'
    }

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

@afonsobspinto afonsobspinto changed the title Feature/ch 188 feat: Make custom on_exit_notify task more flexible Sep 15, 2025
Copy link
Copy Markdown
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 0c20298 into develop Oct 2, 2025
5 of 7 checks passed
@filippomc filippomc deleted the feature/CH-188 branch October 2, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants