Ch 220 keycloak organizations sync on django#819
Merged
Conversation
17 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CloudHarness model library from a custom OpenAPI-based system to Pydantic v2, addressing Keycloak organizations synchronization requirements and implementing significant architectural improvements.
- Replaces custom Flask-based model generation with modern Pydantic v2 models
- Implements enhanced model access patterns with backward compatibility through monkey patches
- Updates dependency management and testing infrastructure for better maintainability
Reviewed Changes
Copilot reviewed 165 out of 167 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tools/deployment-cli-tools/ch_cli_tools/utils.py |
Adds string conversion for environment variable values |
tools/deployment-cli-tools/ch_cli_tools/skaffold.py |
Updates property names from buildArgs to build_args |
tools/deployment-cli-tools/ch_cli_tools/openapi.py |
Changes OpenAPI generator from python-flask to python |
tools/deployment-cli-tools/ch_cli_tools/configurationgenerator.py |
Adds string conversion for tag and value parameters |
libraries/models/tox.ini |
Updates dependencies to use modern Pydantic v2 stack |
libraries/models/test/test_deserialize.py |
Adds comprehensive property access tests for Pydantic models |
libraries/models/test/resources/values.yaml |
Converts numeric values to strings throughout YAML configuration |
libraries/models/test-requirements.txt |
Updates test dependencies with newer versions |
libraries/models/setup.py |
Simplifies dependencies to focus on Pydantic v2 core libraries |
libraries/models/setup.cfg |
Adds flake8 configuration for code style |
libraries/models/pyproject.toml |
Adds modern Python packaging configuration |
libraries/models/docs/*.md |
Generates new documentation for Pydantic-based models |
libraries/models/cloudharness_model/*.py |
Complete rewrite of model classes using Pydantic v2 with enhanced utilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
afonsobspinto
approved these changes
Sep 22, 2025
…20-keycloak-organizations-sync-on-django
…into CH-220-keycloak-organizations-sync-on-django
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-220
Also addresses CH-219 - model updates
Implemented solution
...
How to test this PR
...
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):