feat: remove regular skeleton layer check from rendering and improve visible chunk getting#148
Merged
seankmartin merged 12 commits intofeature/edit-modefrom May 7, 2026
Merged
Conversation
also reuse float array for color
previously was used to avoid double rendering with visible segments
the previous version was leaving some logic in the draw method for filtering chunks. What should instead happen is that the FE filters to only the chunks to draw, and directly gives the chunks to draw to the draw method. The draw method early returns if no chunks, and otherwise just draws them all
seankmartin
changed the title
afonsobspinto
requested changes
May 6, 2026
| } else { | ||
| gl.uniform1ui(shader.uniform("uUseSegmentDefaultColor"), 1); | ||
| gl.uniform3f( | ||
| gl.uniform3fv( |
Member
There was a problem hiding this comment.
I'm getting an error here:
No overload matches this call.
The last overload gave the following error.
Argument of type 'number' is not assignable to parameter of type 'Float32List'.ts(2769)
lib.dom.d.ts(39668, 5): The last overload is declared here.
Author
There was a problem hiding this comment.
I must have put a commit on a different branch sorry, should be just segmentDefaultColor here, not segmentDefaultColor[0], [1], [2]. Will fix
Author
There was a problem hiding this comment.
Fixed in f714b04, I'll merge this as I'm guessing the rest is fine, but if I've assumed wrongly let me know and I'll revert the merge. Thanks for the review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, no major changes, just a little bit clearer in shader binding and then order. Also adds some debug flags which add a little bit of complexity, but I think are worth overall. Other than that is in title.
Next steps to continue with cleaning and helping to debug:
areVisibleChunksReadyNext steps after that:
Worth checking #149 first as this adds new debug options