feat: Target affect chunks only for invalidation after edit operations#153
Merged
Conversation
afonsobspinto
changed the base branch from
refactor/skeleton-frontend
to
feature/edit-mode
seankmartin
approved these changes
May 11, 2026
seankmartin
left a comment
seankmartin
left a comment
There was a problem hiding this comment.
Looks good to me, a note on a comment that's not quite accurate but can change that after
| const { chunkDataSize } = chunkSource.spec; | ||
| for (const position of positionList) { | ||
| // Spatial skeleton node positions are already source/model coordinates; | ||
| // render-layer transforms do not apply to CATMAID grid-cell keys. |
There was a problem hiding this comment.
We should change this comment, not CATMAID specific - applies to any skeleton key
feat: Keep selection when activating edit tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://metacell.atlassian.net/browse/NA-716
To solve it we narrows the stale browse surface to affected cells and makes remaining browse traffic lower browser/network priority, so edit requests do not compete as heavily with large node/list bursts.
The main change is replacing broad CATMAID spatial skeleton browse-cache invalidation with targeted cell invalidation.
CATMAID node/list browse fetches are marked low priority with fetch(..., { priority: "low" })
Fixes regression on merge with non-inspected skeleton that was pulling the full skeleton before the merge