Skip to content

fix: correct isReady check on spatial skeleton layers#163

Merged
afonsobspinto merged 3 commits into
fix/skeleton-highlightfrom
fix/skeleton-screenshot
May 14, 2026
Merged

fix: correct isReady check on spatial skeleton layers#163
afonsobspinto merged 3 commits into
fix/skeleton-highlightfrom
fix/skeleton-screenshot

Conversation

@seankmartin
Copy link
Copy Markdown

@seankmartin seankmartin commented May 13, 2026

Primary effect is that the screenshot of spatial skeletons should be fixed, and also removes a management piece with seen chunks that shouldn't be needed here

  • fix: don't consider lod undefined as not ready
  • fix: isReady considers only current LOD level
  • refactor: remove uneeded seen set management, combine chunk manage paths this allows us to be more maintainable. This bug stemmed from the isReady using a different path for chunk manage then the rendering did

this allows us to be more maintainable. This bug stemmed from the isReady using a
different path for chunk manage then the rendering did
@afonsobspinto afonsobspinto merged commit 3a4b31b into fix/skeleton-highlight May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants