Skip to content

#8 add settings ui#200

Merged
jrmartin merged 5 commits into
developmentfrom
feature/SDSV-8
Jan 11, 2024
Merged

#8 add settings ui#200
jrmartin merged 5 commits into
developmentfrom
feature/SDSV-8

Conversation

@Salam-Dalloul
Copy link
Copy Markdown
Contributor

@Salam-Dalloul Salam-Dalloul commented Jan 8, 2024

Screenshot 2024-01-08 at 3 45 09 PM Screenshot 2024-01-08 at 3 43 21 PM

@Salam-Dalloul Salam-Dalloul marked this pull request as draft January 8, 2024 11:58
@Salam-Dalloul Salam-Dalloul marked this pull request as ready for review January 8, 2024 14:42
@Salam-Dalloul Salam-Dalloul requested a review from jrmartin January 8, 2024 14:42
Copy link
Copy Markdown
Collaborator

@jrmartin jrmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Salam-Dalloul Looks good! I'm approving the PR but not going to merge it yet. I'll add the redux store setting to allow the panel to close before merging it.

@jrmartin jrmartin merged commit bbc7ae0 into development Jan 11, 2024
@jrmartin jrmartin deleted the feature/SDSV-8 branch June 17, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants