#SDSV-24 - Add codefresh deployment pipeline on Metacell kubernetes cluster#214
Merged
Conversation
…d metacell cluster.
zsinnema
approved these changes
Mar 18, 2024
Collaborator
There was a problem hiding this comment.
Hi @jrmartin lgtm
The issue was the "old" (previous) ingress that was also still listening to the incoming traffic.
I removed that one and ran the CF pipeline and everything looks good!
Nice work :-) and thanks for doing this. You can merge it
Collaborator
Author
Thanks Zoran, much appreciated for taking care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add k8s files for kubernetes deployment using codefresh and metacell cluster. https://sds-viewer.dev.metacell.us/
Still needs a cert-manager but not urgent since it's an internal release.