Feature/33 - Latest Test Changes#40
Closed
jrmartin wants to merge 24 commits into
Closed
Conversation
…rk on them. Mocking axios and filereader to test the local file uploads and axios GET call
…rom the edges but the rest seems fine
…nto feature/33
… implementing categories, first draft factory
…into feature/9
Collaborator
Author
|
Needs to be updated, closing for now and reopening once changes are done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ddelpiano @zsinnema
Update on the tests:
To test the downloading of the files, I'm mocking the axios GET call, the downloaded file contents are not tested.
To test the loading of the local files, I'm mocking the FileReader used by the FileHandler class and testing the FileReader.readAsText calls happens inside fileHandler.get_local_file().
The other tests are skeletons for the Splinter class, which will be the tests for the parsing of the turtle and json files. Work in progress.