fix(INFRA-3359): restrict cherry-pick auto-approval to MetaMask org members#85
Merged
Merged
Conversation
…embers Without an author check, any external user could open a fork PR targeting a release/* branch with "cherry-pick" in the title and fewer than 200 LOC, causing policy-bot to post a passing status check. Add `has_author_in: organizations: ["MetaMask"]` to the cherry-pick auto-approval rule so the auto-approval path is only reachable by members of the MetaMask GitHub organization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alucardzom
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cherry-pick auto-approvalhad no author check. On public repos, an external user could open a fork PR matching the title/branch/LOC criteria and get asuccessstatus from policy-bot (status spoofing).Fix
Add
has_author_in: organizations: ["MetaMask"]to the rule'sifblock. Fork PRs from non-members now fall through torelease branch review, which requiresMetaMask/release-teamapproval.Evaluation logic (unchanged for org members)
release/*(<200 LOC)release/*mainJira: INFRA-3359