fix: fix prepare-preview-builds.ts
#444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
changed the title
prepare-preview-builds.ts
danroc
approved these changes
Jan 21, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // (see `updateWorkspaceResolutions`) | ||
| for (const depKey of ['dependencies', 'devDependencies']) { | ||
| const deps = pkgJson.content[depKey] as DependenciesRecord; | ||
| const deps: DependenciesRecord = pkgJson.content[depKey] ?? {}; |
There was a problem hiding this comment.
Empty dependency objects added to package.json unnecessarily
Medium Severity
When pkgJson.content[depKey] is undefined, the fallback ?? {} creates an empty object. The code then unconditionally calls pkgJson.update({ [depKey]: deps }) even when no modifications were made. This adds empty dependencies: {} or devDependencies: {} to package.json files that didn't originally have these fields, polluting the manifests of packages like account-api that don't depend on other workspace packages.
Additional Locations (1)
Contributor
Author
There was a problem hiding this comment.
That's ok. We use preview builds for dev purposes. As long as we're not overwriting any deps, we're good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deps might actually be undefined if some of our packages don't depend on any others (like for the
account-api).So we need to add fallback records for those cases.
Note
Ensures the preview build script tolerates packages without dependency sections.
scripts/prepare-preview-builds.ts, defaultdependenciesandpeerDependenciesto{}before mutation when moving peer deps todependenciesand when pinning workspace versions independencies/devDependenciesdependencies/peerDependenciesWritten by Cursor Bugbot for commit d09be21. This will update automatically on new commits. Configure here.