feat: add optional details field to Transaction type#445
Merged
Conversation
danroc
added
DO-NOT-MERGE
Add optional details field containing transaction origin and security alert response. The details field includes: - origin: transaction request source (e.g., 'metamask' or dapp URL) - securityAlertResponse: Security Alert API response enum (benign, warning, malicious) The implementation uses exactOptional for full backward compatibility.
danroc
force-pushed
the
dr/tx-details
branch
from
18cacd1 to
93db5bd
Compare
danroc
force-pushed
the
dr/tx-details
branch
from
93db5bd to
65305a5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
wzrdk3lly
approved these changes
Feb 23, 2026
wzrdk3lly
left a comment
wzrdk3lly
left a comment
There was a problem hiding this comment.
Thanks this looks good. Correct the successful responses types from security alerts are Benign | Warning | Malicious .
Contributor
Author
|
Thanks @wzrdk3lly, I updated the enum to match the casing. |
danroc
force-pushed
the
dr/tx-details
branch
from
dcd9db3 to
378326d
Compare
hmalik88
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional
detailsfield to theTransactiontype to support transaction origin tracking and security alert responses.Current State
The
Transactiontype currently lacks fields to track:Solution
Adds an optional
detailsobject containing:origin(optional string): Transaction request source (e.g., 'metamask' or dapp URL)securityAlertResponse(optional enum): Security Alert API response (Benign,Warning,Malicious)The implementation is backward compatible.
Examples
N/A - This is an API enhancement that consumers can adopt incrementally.