Conversation
Base automatically changed from
cc/feat/deterministic-uuid-for-evm-for-keyring-v2
to
main
April 8, 2026 14:38
f1f7fd0 to
47c6e37
Compare
generateEthAccountId + use it in EthKeyringWrapper
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 47c6e37. Configure here.
gantunesr
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change how account ID are generate for
EthKeyringWrapperso IDs are now deterministic (similarly to what theAccountsControlleris doing today).Note
Medium Risk
Changes how
EthKeyringWrappergeneratesAccountIds (from random UUIDs to deterministic IDs derived from addresses), which can affect persisted IDs and any consumers relying on ID stability/uniqueness semantics across sessions.Overview
Introduces
generateEthAccountId, a deterministic UUIDv4-likeAccountIdgenerator derived from a normalized EVM address hash, and exports it from the SDK.Updates
KeyringWrapperto acceptregistryOptions, and updatesEthKeyringWrapperto always configure its registry to usegenerateEthAccountId(preventing custom registry configuration). Adds unit tests for the new generator and wrapper behavior, and adjusts multiple keyring wrapper tests (HD/Ledger/QR/Simple/Trezor) to assert IDs remain stable acrossdeserialize/registry rebuilds; also updates Trezor fixtures used in tests.Adds
ethereum-cryptographyas a dependency and updates thekeyring-sdkchangelog/lockfile accordingly.Reviewed by Cursor Bugbot for commit f8f5415. Bugbot is set up for automated code reviews on this repo. Configure here.