feat(keyring-eth-hd): add keyring v2 getters#529
Merged
Conversation
mathieuartu
approved these changes
Apr 27, 2026
Contributor
mathieuartu
left a comment
There was a problem hiding this comment.
LGTM! Worth scanning if we'd need to do this for other types of V2 keyrings as well. But this PR can be merged regardless!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-expose the same getters than the v1 (inner) keyring, so we can use v2 keyrings to replace their current usage.
Note
Medium Risk
Adds new public accessors that expose sensitive key material (mnemonic/seed/HD keys) through the v2 wrapper; while pass-through, it can broaden where secrets are accessed and relied upon.
Overview
Re-exposes legacy HD keyring state on the v2
HdKeyringwrapper by adding passthrough getters formnemonic,seed,root,hdWallet, andhdPath(returningundefinedpre-deserialization) to maintain compatibility with v1 consumers.Adds unit tests asserting the getters mirror the inner keyring values and updates the changelog to document the new API surface.
Reviewed by Cursor Bugbot for commit c56bb3b. Bugbot is set up for automated code reviews on this repo. Configure here.