Skip to content

feat(keyring-eth-hd): add keyring v2 getters#529

Merged
ccharly merged 4 commits intomainfrom
cc/feat/hd-keyring-v2-getters
Apr 27, 2026
Merged

feat(keyring-eth-hd): add keyring v2 getters#529
ccharly merged 4 commits intomainfrom
cc/feat/hd-keyring-v2-getters

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 27, 2026

Re-expose the same getters than the v1 (inner) keyring, so we can use v2 keyrings to replace their current usage.


Note

Medium Risk
Adds new public accessors that expose sensitive key material (mnemonic/seed/HD keys) through the v2 wrapper; while pass-through, it can broaden where secrets are accessed and relied upon.

Overview
Re-exposes legacy HD keyring state on the v2 HdKeyring wrapper by adding passthrough getters for mnemonic, seed, root, hdWallet, and hdPath (returning undefined pre-deserialization) to maintain compatibility with v1 consumers.

Adds unit tests asserting the getters mirror the inner keyring values and updates the changelog to document the new API surface.

Reviewed by Cursor Bugbot for commit c56bb3b. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly marked this pull request as ready for review April 27, 2026 09:01
@ccharly ccharly requested a review from a team as a code owner April 27, 2026 09:01
Copy link
Copy Markdown
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Worth scanning if we'd need to do this for other types of V2 keyrings as well. But this PR can be merged regardless!

@ccharly ccharly added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 2afa37b Apr 27, 2026
40 checks passed
@ccharly ccharly deleted the cc/feat/hd-keyring-v2-getters branch April 27, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants