build: fix yarn warnings + align typescript version with core/snaps#536
Merged
build: fix yarn warnings + align typescript version with core/snaps#536
yarn warnings + align typescript version with core/snaps#536Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
typescript version with core/snaps
typescript version with core/snapsyarn warnings + align typescript version with core/snaps
danroc
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixing
yarnwarnings by updating some depsImportant
We previously upgraded to ts 5.6.3 as this was a suggestion that would get in pair with the new usage of
ts-bridge, but none of our core monorepos are using this version, so I prefer to align it to follow the same pattern everywhere!Note
Medium Risk
Moderate risk because it changes the TypeScript compiler version across workspaces, which can affect typechecking output and build behavior, though no runtime code paths are modified.
Overview
Aligns the monorepo’s toolchain to reduce
yarnwarnings by downgradingtypescriptfrom~5.6.3to~5.3.3across the root and multiple packages (including addingtypescriptwhere it was missing).Bumps the formatting tool
oxfmtto^0.45.0and updatesyarn.lockaccordingly, plus a small refactor inhd-keyring.test.tsandmoney-keyring.test.tsto avoid direct indexed access in assertions.Reviewed by Cursor Bugbot for commit 8d5fde7. Bugbot is set up for automated code reviews on this repo. Configure here.