Merged
Conversation
kanthesha
reviewed
Aug 21, 2024
| - Try to explain each change in terms that users of the package would understand (e.g. avoid referencing internal variables/concepts). | ||
| - Consolidate related changes into one change entry if it makes it easier to explain. | ||
| - Run `yarn auto-changelog validate --rc` to check that the changelog is correctly formatted. | ||
| - Run `yarn auto-changelog validate --prettier --rc` to check that the changelog is correctly formatted. |
Contributor
There was a problem hiding this comment.
The changelog is in prettier format. without --prettier, changelog validate will fail.
Member
There was a problem hiding this comment.
Do you think this could be addressed in a separate PR?
mikesposito
reviewed
Aug 21, 2024
| - Try to explain each change in terms that users of the package would understand (e.g. avoid referencing internal variables/concepts). | ||
| - Consolidate related changes into one change entry if it makes it easier to explain. | ||
| - Run `yarn auto-changelog validate --rc` to check that the changelog is correctly formatted. | ||
| - Run `yarn auto-changelog validate --prettier --rc` to check that the changelog is correctly formatted. |
Member
There was a problem hiding this comment.
Do you think this could be addressed in a separate PR?
mikesposito
reviewed
Aug 21, 2024
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 3.0.1.