fix: add caip-27 + fix strings in yaml for multichain #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
reviewed
Jun 26, 2024
Comment on lines
+25
to
+26
| params: | ||
| true |
Contributor
There was a problem hiding this comment.
just making sure this is the correct way to specify optional params
Contributor
Author
There was a problem hiding this comment.
its not optional but true here would just mean any if it was typescript
jiexi
approved these changes
Jun 26, 2024
adonesky1
reviewed
Jun 26, 2024
| method: eth_getBalance | ||
| params: [] | ||
| - name: sessionId | ||
| value: "0xdeadbeef" |
Contributor
There was a problem hiding this comment.
is it only values that should remain strings?
Contributor
Author
There was a problem hiding this comment.
if i did it with this:
0xdeadbeef without the string wrapping then yaml would think its a hex number
adonesky1
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.