Skip to content

Fix TypedData schema #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix TypedData schema #252

merged 1 commit into from
Aug 22, 2024

Conversation

@alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Aug 21, 2024

The TypedData parameter is throwing an error on the current reference:
Screenshot 2024-08-21 at 1 33 16 PM

And the new reference:
Screenshot 2024-08-21 at 1 33 41 PM

This PR adds the required items property for the EIP712Domain array schema.

@alexandratran alexandratran requested a review from a team as a code owner August 21, 2024 20:35
@shanejonas shanejonas merged commit 0ced2b0 into MetaMask:main Aug 22, 2024
@alexandratran alexandratran deleted the fix-typeddata branch August 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shanejonas shanejonas shanejonas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandratran @shanejonas