Add rpl token image and contract information #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRabenda
reviewed
Apr 4, 2022
contract-map.json
Outdated
| }, | ||
| "0xD33526068D116cE69F19A9ee46F0bd304F21A51f": { | ||
| "name": "Rocket Pool", | ||
| "logo": "rpl.png", |
Contributor
Author
There was a problem hiding this comment.
Unfortunately the icon uses some complex gradients and subtle shadows which don't scale well using an SVG, which is why we've opted with a png (we don't have SVGs available because of the gradient scaling).
Is there any flexibility around using a png?
Contributor
Author
There was a problem hiding this comment.
Have replaced with an SVG as requested.
Contributor
Author
|
Any update on this? Requested changes have been made. |
Collaborator
|
SVG image size is still too big - regular on should have around 5kB - if you can decrease you 200kB to sth around 20-30kB would be great |
Contributor
Author
|
Reduced file size to 16kb. |
MRabenda
approved these changes
May 5, 2022
Collaborator
|
Can you merge master and solve conflicts - I am not able to merge it |
Contributor
Author
|
Fixed merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token address is inserted according to the EIP-55 format.
About RPL:
Rocket Pool smart contracts accept ETH deposits, assign them to node operators, and issue & track various tokens (RPL/rETH) and handle interactions with the beacon chain.
Etherscan: https://etherscan.io/token/0xD33526068D116cE69F19A9ee46F0bd304F21A51f
Official Website: https://rocketpool.net/
Official Forum: https://dao.rocketpool.net/
Contact: contact@rocketpool.net
Twitter: https://twitter.com/Rocket_Pool
CoinGecko: https://www.coingecko.com/en/coins/rocket-pool
CoinMarketCap: https://coinmarketcap.com/currencies/rocket-pool/