Skip to content

Fix typos and improve clarity in documentation files#120

Merged
mcmire merged 3 commits intoMetaMask:mainfrom
Dimitrolito:fix/typos
Dec 9, 2024
Merged

Fix typos and improve clarity in documentation files#120
mcmire merged 3 commits intoMetaMask:mainfrom
Dimitrolito:fix/typos

Conversation

@Dimitrolito
Copy link
Copy Markdown
Contributor

This pull request addresses several minor typos and grammatical issues in multiple documentation files:

  1. Fixed incorrect use of "a" instead of "an" in the "migrations-guidelines.md" file.
  2. Corrected the hyphenation of "up to date" in the "pull-requests.md" file.
  3. Corrected the article usage ("a" to "an") in the "extension-e2e-guidelines.md" file.

These changes enhance the clarity and correctness of the documentation.

Issue(s) Fixed:

No specific issue fixed, general documentation improvement.

Preview:

Link to the preview (if applicable)

Checklist:

  • Reviewed and approved by a team member.
  • Changes adhere to the contributing guidelines.

@Dimitrolito Dimitrolito requested a review from a team as a code owner December 9, 2024 15:18
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Comment thread docs/pull-requests.md
### Create smaller pull requests

Large pull requests are extremely painful to review. They also need to be kept up to date more frequently since they have a higher chance of creating conflicts that need to be resolved, and they make the commit history more difficult to understand after they are merged.
Large pull requests are extremely painful to review. They also need to be kept up-to-date more frequently since they have a higher chance of creating conflicts that need to be resolved, and they make the commit history more difficult to understand after they are merged.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prosodically, it sounds like it ought to be "up to date". The internet is divided over this one, but grammatically I think you might be correct.

@mcmire mcmire merged commit 63d5d17 into MetaMask:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants