Add updateRequestState action to ApprovalController#1059
Merged
Conversation
GuillaumeRx
force-pushed
the
gr/allow-approval-update
branch
from
2e2020d to
7db0ca0
Compare
Gudahtt
changed the title
udateRequestData action to ApprovalControllerupdateRequestData action to ApprovalController
FrederikBolding
previously requested changes
Jan 12, 2023
Member
FrederikBolding
left a comment
FrederikBolding
left a comment
There was a problem hiding this comment.
Code LGTM. I will hold off on approving until we get some feedback on the general idea.
GuillaumeRx
changed the title
updateRequestData action to ApprovalControllerupdateRequestState action to ApprovalController
GuillaumeRx
force-pushed
the
gr/allow-approval-update
branch
from
8dfd6b9 to
202e53a
Compare
GuillaumeRx
force-pushed
the
gr/allow-approval-update
branch
from
a989425 to
da74211
Compare
FrederikBolding
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1056
Please see above issue for motivation behind this addition.