Exclude types from rate limiting in approval controller#1185
Merged
matthewwalsh0 merged 3 commits intoApr 14, 2023
Conversation
matthewwalsh0
changed the title
cryptotavares
previously approved these changes
Apr 14, 2023
Contributor
cryptotavares
left a comment
cryptotavares
left a comment
There was a problem hiding this comment.
Looks good! ✅
just left some very minor comments.
vinistevam
approved these changes
Apr 14, 2023
cryptotavares
approved these changes
Apr 14, 2023
matthewwalsh0
deleted the
feat/approval-controller-disable-rate-limiting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently all approval requests created by the
ApprovalControllerare rate limited to a single pending approval request for each approval type and origin combination.This is not yet required for some existing approval flows being migrated to use the
ApprovalControllerhence the need for a way to exclude specific approval types from rate limiting to avoid any regressions in functionality and user expectation.Changes
typesExcludedFromRateLimitingparameter to theApprovalControllerconstructor to disable rate limiting for specific approval types._originsproperty to support multiple requests with same origin and type.References
[Bug]: Approval request with id not found.
Checklist