Remove @metamask/types#1372
Merged
Merged
Conversation
The `@metamask/types` package is no longer actively maintained, so it has been removed. Most types we used to get from there were migrated to `@metamask/utils` or can be gotten from `json-rpc-engine`. Just one type had no replacement: `PermittedHandlerExport`. Since it is specific to the permission controller anyway, it was added to that package directly.
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: @metamask/types@1.1.0 |
legobeat
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
@metamask/typespackage is no longer actively maintained, so it has been removed. Most types we used to get from there were migrated to@metamask/utilsor can be gotten fromjson-rpc-engine.Just one type had no replacement:
PermittedHandlerExport. Since it is specific to the permission controller anyway, it was added to that package directly.Changes
permissionRpcMethodshas a slightly different type; the second generic type variable of thegetPermissionshandler is nowundefinedrather thanvoid@metamask/typesdependency has been removedReferences
None
Checklist