Skip to content

Remove @metamask/types#1372

Merged
Gudahtt merged 1 commit into
mainfrom
replace-types-package
May 12, 2023
Merged

Remove @metamask/types#1372
Gudahtt merged 1 commit into
mainfrom
replace-types-package

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 12, 2023

Description

The @metamask/types package is no longer actively maintained, so it has been removed. Most types we used to get from there were migrated to @metamask/utils or can be gotten from json-rpc-engine.

Just one type had no replacement: PermittedHandlerExport. Since it is specific to the permission controller anyway, it was added to that package directly.

Changes

  • CHANGED: The export permissionRpcMethods has a slightly different type; the second generic type variable of the getPermissions handler is now undefined rather than void
  • CHANGED: The @metamask/types dependency has been removed

References

None

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

The `@metamask/types` package is no longer actively maintained, so it
has been removed. Most types we used to get from there were migrated to
`@metamask/utils` or can be gotten from `json-rpc-engine`.

Just one type had no replacement: `PermittedHandlerExport`. Since it is
specific to the permission controller anyway, it was added to that
package directly.
@Gudahtt Gudahtt requested a review from a team as a code owner May 12, 2023 17:41
@socket-security
Copy link
Copy Markdown

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Filesystem access ✅ 0 issues
Network access ✅ 0 issues
Shell access ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
No bug tracker ✅ 0 issues
No contributors or author data ✅ 0 issues
No README ✅ 0 issues
Deprecated ✅ 0 issues
New author ✅ 0 issues
Unstable ownership ✅ 0 issues
Non-existent author ✅ 0 issues
Unmaintained ✅ 0 issues
Unpublished package ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @metamask/types@1.1.0

@Gudahtt Gudahtt merged commit b1f9cd7 into main May 12, 2023
@Gudahtt Gudahtt deleted the replace-types-package branch May 12, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants