Support optional result indication when accepting an approval request#1396
Merged
Conversation
bergarces
reviewed
May 26, 2023
bergarces
reviewed
May 26, 2023
bergarces
approved these changes
May 30, 2023
vinistevam
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the
acceptmethod of theApprovalControllerto return a promise which optionally only resolves once the approval request creator has indicated the success or failure of any post-approval logic.This is achieved using callbacks optionally provided in the approval request promise.
This is necessary to support more complex approval flows in which the request acceptor, typically a client frontend, must know the success of the resulting logic, or must receive some resulting data.
Changes
waitForResultoption toacceptmethod to resolve new promise when success or failure is indicated.expectsResultoption toaddandaddAndShowApprovalRequestmethod to change the resolved promise to return a result object including thevalueand newresultCallbacks.expectsResultproperty toApprovalRequestto store return type preference in state.AddResult,AcceptResult,AcceptResultCallbacks, andAcceptOptions.Checklist