Skip to content

Fixed issue with type types from permissions rpc methods#1464

Merged
shanejonas merged 3 commits into
mainfrom
fix/permissions-rpc-method-tuple-types
Jun 29, 2023
Merged

Fixed issue with type types from permissions rpc methods#1464
shanejonas merged 3 commits into
mainfrom
fix/permissions-rpc-method-tuple-types

Conversation

@shanejonas
Copy link
Copy Markdown
Contributor

Had this odd issue with these tuple types when importing into mobile. This fixes it by explicitly stating the tuple types.

@shanejonas shanejonas requested a review from a team as a code owner June 29, 2023 18:28
@shanejonas
Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask/address-book-controller": "3.0.0-preview.07188f4",
  "@metamask/announcement-controller": "4.0.0-preview.07188f4",
  "@metamask/approval-controller": "3.3.0-preview.07188f4",
  "@metamask/assets-controllers": "9.2.0-preview.07188f4",
  "@metamask/base-controller": "3.0.0-preview.07188f4",
  "@metamask/composable-controller": "3.0.0-preview.07188f4",
  "@metamask/controller-utils": "4.0.1-preview.07188f4",
  "@metamask/ens-controller": "4.0.0-preview.07188f4",
  "@metamask/gas-fee-controller": "6.0.0-preview.07188f4",
  "@metamask/keyring-controller": "6.0.0-preview.07188f4",
  "@metamask/logging-controller": "1.0.0-preview.07188f4",
  "@metamask/message-manager": "7.0.1-preview.07188f4",
  "@metamask/network-controller": "10.2.0-preview.07188f4",
  "@metamask/notification-controller": "3.0.0-preview.07188f4",
  "@metamask/permission-controller": "4.0.0-preview.07188f4",
  "@metamask/phishing-controller": "5.0.0-preview.07188f4",
  "@metamask/preferences-controller": "4.1.0-preview.07188f4",
  "@metamask/rate-limit-controller": "3.0.0-preview.07188f4",
  "@metamask/signature-controller": "5.0.0-preview.07188f4",
  "@metamask/transaction-controller": "7.0.0-preview.07188f4"
}

Cal-L
Cal-L previously approved these changes Jun 29, 2023
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/permission-controller/src/rpc-methods/index.ts Outdated
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@shanejonas
Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask/address-book-controller": "3.0.0-preview.347e4fc",
  "@metamask/announcement-controller": "4.0.0-preview.347e4fc",
  "@metamask/approval-controller": "3.3.0-preview.347e4fc",
  "@metamask/assets-controllers": "9.2.0-preview.347e4fc",
  "@metamask/base-controller": "3.0.0-preview.347e4fc",
  "@metamask/composable-controller": "3.0.0-preview.347e4fc",
  "@metamask/controller-utils": "4.0.1-preview.347e4fc",
  "@metamask/ens-controller": "4.0.0-preview.347e4fc",
  "@metamask/gas-fee-controller": "6.0.0-preview.347e4fc",
  "@metamask/keyring-controller": "6.0.0-preview.347e4fc",
  "@metamask/logging-controller": "1.0.0-preview.347e4fc",
  "@metamask/message-manager": "7.0.1-preview.347e4fc",
  "@metamask/network-controller": "10.2.0-preview.347e4fc",
  "@metamask/notification-controller": "3.0.0-preview.347e4fc",
  "@metamask/permission-controller": "4.0.0-preview.347e4fc",
  "@metamask/phishing-controller": "5.0.0-preview.347e4fc",
  "@metamask/preferences-controller": "4.1.0-preview.347e4fc",
  "@metamask/rate-limit-controller": "3.0.0-preview.347e4fc",
  "@metamask/signature-controller": "5.0.0-preview.347e4fc",
  "@metamask/transaction-controller": "7.0.0-preview.347e4fc"
}

@shanejonas shanejonas merged commit 535d84e into main Jun 29, 2023
@shanejonas shanejonas deleted the fix/permissions-rpc-method-tuple-types branch June 29, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants