Conversation
|
|
||
| ## [3.2.1] | ||
| ### Changed | ||
| - There are no consumer-facing changes to this package. This version is a part of a synchronized release across all packages in our monorepo. |
There was a problem hiding this comment.
Should we do this for controller-utils as well? It's the only package not included in this release at the moment
There was a problem hiding this comment.
To consider the contrary: Is it actually worth it to publish a no-op release - could we skip base-controller (and any dependent which by this also becomes identical to previous version and didn't have any other dep updates since its last release) for this release? Not sure I understand the upside here.
There was a problem hiding this comment.
The create-release-branch tool we use to create releases highlights every package with changes when you go to create a new release, with the expectation that the author of the release PR would review each of these packages to determine whether they need to be released (and if so, which version they should have).
This release is intended to clear the slate, so that future releases are easier to manage.
This situation will be less of a problem soon (we have some improvements to create-release-branch that we'll be working on soon to make it a bit smarter about releasing one package without the others safely). But that's a week or two out at best.
There was a problem hiding this comment.
That's true. We also changed how packages refer to other packages within the monorepo. Now they use static versions always instead of dynamic versions which get resolved at publish-time. So we also want to publish every package regardless of whether there were actual changes to ensure that all packages have up-to-date references (and expose any issues that we may see as a result of this change sooner rather than later).
|
Ready for another review. |
4 participants
This release is somewhat special. Most of these packages are just bumping dependencies on other packages within the monorepo. We recently made a change which ensures that if the version of a package A is bumped, then the new version of A is reflected in the manifest of packages that depend on A. This doesn't necessarily mean that those packages need to be released right away — it's fine if just A is released — but we are releasing every package right now to reduce the amount of changes that need to be published in the next release.