Merged
Conversation
BelfordZ
force-pushed
the
selected-network-controller
branch
2 times, most recently
from
0f0b98e to
04c2e62
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mcmire
reviewed
Aug 31, 2023
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Nice design and good job with the package structure. A lot of the comments I have are style-related.
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
packages/selected-network-controller/tests/SelectedNetworkController.test.ts
Outdated
Show resolved
Hide resolved
packages/selected-network-controller/tests/SelectedNetworkController.test.ts
Outdated
Show resolved
Hide resolved
packages/selected-network-controller/tests/SelectedNetworkMiddleware.test.ts
Show resolved
Hide resolved
packages/selected-network-controller/src/SelectedNetworkMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/selected-network-controller/tests/SelectedNetworkController.test.ts
Outdated
Show resolved
Hide resolved
BelfordZ
force-pushed
the
selected-network-controller
branch
from
2114396 to
405f3db
Compare
jiexi
reviewed
Aug 31, 2023
jiexi
reviewed
Aug 31, 2023
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
jiexi
reviewed
Aug 31, 2023
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
jiexi
reviewed
Aug 31, 2023
packages/selected-network-controller/tests/SelectedNetworkMiddleware.test.ts
Outdated
Show resolved
Hide resolved
BelfordZ
commented
Sep 5, 2023
BelfordZ
commented
Sep 5, 2023
BelfordZ
commented
Sep 5, 2023
BelfordZ
force-pushed
the
selected-network-controller
branch
from
edbdb8a to
6bc5e1d
Compare
…ller.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
BelfordZ
force-pushed
the
selected-network-controller
branch
from
7cd22aa to
09d36f3
Compare
jiexi
reviewed
Sep 7, 2023
| Domain here means one of two things: | ||
|
|
||
| - the jsonrpc request originated from a dapp (domain is the origin/url of the dapp) | ||
| - the jsonrpc request originated interally to metamask (the domain is here is 'metamask') |
jiexi
reviewed
Sep 7, 2023
| branches: 100, | ||
| functions: 100, | ||
| lines: 100, | ||
| statements: 100, |
jiexi
approved these changes
Sep 7, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added SelectedNetworkController * Update packages/selected-network-controller/src/SelectedNetworkController.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * use jsdoc Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * remove whitespace * update year in license * readme grammar fixup * fix test case wording Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * pr review fixups * dont use default export * Fix private method syntax * Remove resetState method * fix exports and type naming * remove using any * Changed middleware to take a single messenger * fixup test to use real messenger * fixup test to use real messenger * lint fix --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added SelectedNetworkController * Update packages/selected-network-controller/src/SelectedNetworkController.ts Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * use jsdoc Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * remove whitespace * update year in license * readme grammar fixup * fix test case wording Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> * pr review fixups * dont use default export * Fix private method syntax * Remove resetState method * fix exports and type naming * remove using any * Changed middleware to take a single messenger * fixup test to use real messenger * fixup test to use real messenger * lint fix --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This is a PR which moves the proposed Selected Network Controller out of extension.
It also adds tests (coverage @ 100%)
References
fixes https://github.com/MetaMask/MetaMask-planning/issues/1006
Changelog
@metamask/selected-network-controllerChecklist