Skip to content

Add incoming transactions to preferences controller#1659

Merged
tommasini merged 9 commits into
mainfrom
feat/1188-incoming-transactions
Oct 24, 2023
Merged

Add incoming transactions to preferences controller#1659
tommasini merged 9 commits into
mainfrom
feat/1188-incoming-transactions

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Sep 7, 2023

References

More info here

Changelog

@metamask/package-a

  • : Show incoming transactions per network on preferences controller

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini tommasini requested a review from a team as a code owner September 7, 2023 07:55
Comment thread packages/preferences-controller/src/PreferencesController.ts Outdated
Comment thread packages/preferences-controller/src/PreferencesController.ts Outdated
Comment thread packages/preferences-controller/src/PreferencesController.ts
Comment thread packages/preferences-controller/src/PreferencesController.test.ts Outdated
@tommasini tommasini requested a review from MajorLift October 23, 2023 20:03
Comment thread packages/preferences-controller/src/PreferencesController.ts
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini merged commit c9bdd29 into main Oct 24, 2023
@tommasini tommasini deleted the feat/1188-incoming-transactions branch October 24, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants