Skip to content

Add title and icon options to result page methods#3675

Merged
matthewwalsh0 merged 2 commits into
mainfrom
feat/result-pages-title-icon-config
Dec 18, 2023
Merged

Add title and icon options to result page methods#3675
matthewwalsh0 merged 2 commits into
mainfrom
feat/result-pages-title-icon-config

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

Explanation

Add icon and title options to the success and error methods to provide custom title text or a custom icon when creating standard result pages. Both elements can also be hidden using null.

In addition, remove all usages of the any type following the updated linting rules.

Changelog

@metamask/approval-controller

  • ADDED: Add title and icon options to success and error methods.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner December 16, 2023 15:29
@matthewwalsh0 matthewwalsh0 merged commit c86d506 into main Dec 18, 2023
@matthewwalsh0 matthewwalsh0 deleted the feat/result-pages-title-icon-config branch December 18, 2023 20:09
@matthewwalsh0 matthewwalsh0 added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-confirmations-system DEPRECATED: please use "team-confirmations" label instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants